Skip to content

[Ingest Manager] Update registry URL to point to CDN #73533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Ingest Manager] Update registry URL to point to CDN #73533

wants to merge 1 commit into from

Conversation

@ruflin
Copy link
Contributor

@ruflin ruflin commented Jul 28, 2020

When the change was made for snapshot, the CDN url was not available yet. Now that is is available, the new url is used.

@ruflin
[Ingest Manager] Update registry URL to point to CDN
364f068 
When the change was made for snapshot, the CDN url was not available yet. Now that is is available, the new url is used.
@ruflin ruflin added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 28, 2020
@ruflin ruflin requested a review from a team July 28, 2020 18:58
@ruflin ruflin self-assigned this Jul 28, 2020
@elasticmachine
Copy link
Contributor

elasticmachine commented Jul 28, 2020

Pinging @elastic/ingest-management (Team:Ingest Management)

@ruflin
Copy link
Contributor Author

ruflin commented Jul 28, 2020

@skh Seeing the change you made for the reference of the query param based on the branch name, I wonder if we should implement something similar here? Not for this PR but as a follow up.

@kibanamachine
Copy link
Contributor

kibanamachine commented Jul 28, 2020

💚 Build Succeeded

Build metrics

page load bundle size

id value diff baseline
ingestManager 458.8KB -8.0B 458.8KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jfsiii
Copy link
Contributor

jfsiii commented Jul 28, 2020

@skh Seeing the change you made for the reference of the query param based on the branch name, I wonder if we should implement something similar here? Not for this PR but as a follow up.

@ruflin @skh take a look at #73555 when you get a moment

@ruflin
Copy link
Contributor Author

ruflin commented Jul 29, 2020

@jfsiii Thanks for taking over. Closing this in favor of #73555

@ruflin ruflin closed this Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jfsiii jfsiii jfsiii approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ruflin ruflin

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ruflin @elasticmachine @kibanamachine @jfsiii